netdev - Re: [PATCH] thunderbolt: Drop sequence number check from tb_xdomain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171027.120141.2030619458420639672.davem@davemloft.net>
Date:   Fri, 27 Oct 2017 12:01:41 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     mika.westerberg@...ux.intel.com
Cc:     andreas.noever@...il.com, michael.jamet@...el.com,
        yehezkel.bernat@...el.com, dan.carpenter@...cle.com,
        amir.jer.levy@...el.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] thunderbolt: Drop sequence number check from
 tb_xdomain_match()

From: Mika Westerberg <mika.westerberg@...ux.intel.com>
Date: Wed, 25 Oct 2017 12:27:34 +0300

> Commit 9a03c3d398c1 ("thunderbolt: Fix a couple right shifting to zero
> bugs") revealed an issue that was previously hidden because we never
> actually compared received XDomain message sequence numbers properly.
> The idea with these sequence numbers is that the responding host uses
> the same sequence number that was in the request packet which we can
> then check at the requesting host.
> 
> However, testing against macOS it looks like it does not follow this but
> instead uses some other logic. Windows driver on the other hand handles
> it the same way than Linux.
> 
> In order to be able to talk to macOS again, fix this so that we drop the
> whole sequence number check. This effectively works exactly the same
> than it worked before the aforementioned commit. This also follows the
> logic the original P2P networking code used.
> 
> Signed-off-by: Mika Westerberg <mika.westerberg@...ux.intel.com>
> ---
> This applies on top of net-next.git/master.

Applied, thank you.