netdev - Re: [PATCH net-next v6 2/2] bridge: vlan: signal if anything changed on vlan add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <01acc055-ad4e-c35b-e6b5-5f0493e9c5ac@gmail.com>
Date:   Sat, 28 Oct 2017 08:34:03 +0900
From:   Toshiaki Makita <toshiaki.makita1@...il.com>
To:     Nikolay Aleksandrov <nikolay@...ulusnetworks.com>,
        netdev@...r.kernel.org
Cc:     dsa@...ulusnetworks.com, mrv@...atatu.com, davem@...emloft.net,
        bridge@...ts.linux-foundation.org, roopa@...ulusnetworks.com,
        stephen@...workplumber.org, makita.toshiaki@....ntt.co.jp
Subject: Re: [PATCH net-next v6 2/2] bridge: vlan: signal if anything changed
 on vlan add

On 17/10/27 (金) 19:19, Nikolay Aleksandrov wrote:
> Before this patch there was no way to tell if the vlan add operation
> actually changed anything, thus we would always generate a notification
> on adds. Let's make the notifications more precise and generate them
> only if anything changed, so use the new bool parameter to signal that the
> vlan was updated. We cannot return an error because there are valid use
> cases that will be broken (e.g. overlapping range add) and also we can't
> risk masking errors due to calls into drivers for vlan add which can
> potentially return anything.
>
> Signed-off-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>

Reviewed-by: Toshiaki Makita <makita.toshiaki@....ntt.co.jp>

Toshiaki Makita