netdev - Re: [PATCH net-next] tcp: add tracepoint trace_tcp_retransmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <D81267F3-4447-4375-B2A8-06F92FAF4ACD@fb.com>
Date:   Fri, 27 Oct 2017 05:06:28 +0000
From:   Song Liu <songliubraving@...com>
To:     Cong Wang <xiyou.wangcong@...il.com>
CC:     kbuild test robot <lkp@...el.com>,
        David Miller <davem@...emloft.net>,
        "kbuild-all@...org" <kbuild-all@...org>,
        "alexei.starovoitov@...il.com" <alexei.starovoitov@...il.com>,
        Martin Lau <kafai@...com>, Alexei Starovoitov <ast@...com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "liu.song.a23@...il.com" <liu.song.a23@...il.com>
Subject: Re: [PATCH net-next] tcp: add tracepoint
 trace_tcp_retransmit_synack()


> On Oct 26, 2017, at 7:01 PM, Cong Wang <xiyou.wangcong@...il.com> wrote:
> 
> On Thu, Oct 26, 2017 at 4:50 PM, Song Liu <songliubraving@...com> wrote:
>> In this case, we are putting CONFIG_IPV6 in TRACE_EVENT macro, which generates
>> warnings like:
>> 
>> ./include/trace/events/tcp.h:274:1: error: directive in argument list
>> ./include/trace/events/tcp.h:281:1: error: directive in argument list
>> 
>> Seems these warning cannot be easily avoided. This is also the same pattern we
>> have been using in include/trace/events/tcp.h.
> 
> Hmm, we use the same so why it only complains about this one?\

sparse reports same warning for all the lines in tcp.h. Don't know why
kbuild test bot only complains about this patch. 

> 
>> 
>> Any suggestions on how shall we proceed from here?
>> 
> 
> I think this warning is harmless, so perhaps not worthy time to
> shut it up, unless sparse provides a simple way to do so.