| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <201710290638.J4uakNIt%fengguang.wu@intel.com>
Date: Sun, 29 Oct 2017 06:21:59 +0800
From: kbuild test robot <lkp@...el.com>
To: Manish Kurup <kurup.manish@...il.com>
Cc: kbuild-all@...org, jhs@...atatu.com, xiyou.wangcong@...il.com,
jiri@...nulli.us, davem@...emloft.net, netdev@...r.kernel.org,
aring@...atatu.com, mrv@...atatu.com, kurup.manish@...il.com,
Manish Kurup <manish.kurup@...izon.com>
Subject: Re: [PATCH net-next 2/2] net sched act_vlan: VLAN action rewrite to
use RCU lock/unlock and update
Hi Manish,
Thank you for the patch! Yet we hit a small issue.
[auto build test ERROR on net-next/master]
url: https://github.com/0day-ci/linux/commits/Manish-Kurup/net-sched-act_vlan-Change-stats-update-to-use-per-core-stats/20171029-053449
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 6.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=ia64
All errors (new ones prefixed by >>):
In file included from include/asm-generic/bug.h:4:0,
from arch/ia64/include/asm/bug.h:12,
from include/linux/bug.h:4,
from include/linux/bitfield.h:18,
from drivers/net/ethernet/netronome/nfp/flower/action.c:34:
drivers/net/ethernet/netronome/nfp/flower/action.c: In function 'nfp_fl_push_vlan':
>> drivers/net/ethernet/netronome/nfp/flower/action.c:70:41: error: 'struct tcf_vlan' has no member named 'tcfv_push_prio'
FIELD_PREP(NFP_FL_PUSH_VLAN_PRIO, vlan->tcfv_push_prio) |
^
include/linux/compiler.h:553:19: note: in definition of macro '__compiletime_assert'
bool __cond = !(condition); \
^~~~~~~~~
include/linux/compiler.h:576:2: note: in expansion of macro '_compiletime_assert'
_compiletime_assert(condition, msg, __compiletime_assert_, __LINE__)
^~~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:46:37: note: in expansion of macro 'compiletime_assert'
#define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
^~~~~~~~~~~~~~~~~~
include/linux/bitfield.h:56:3: note: in expansion of macro 'BUILD_BUG_ON_MSG'
BUILD_BUG_ON_MSG(__builtin_constant_p(_val) ? \
^~~~~~~~~~~~~~~~
include/linux/bitfield.h:88:3: note: in expansion of macro '__BF_FIELD_CHECK'
__BF_FIELD_CHECK(_mask, 0ULL, _val, "FIELD_PREP: "); \
^~~~~~~~~~~~~~~~
drivers/net/ethernet/netronome/nfp/flower/action.c:70:3: note: in expansion of macro 'FIELD_PREP'
FIELD_PREP(NFP_FL_PUSH_VLAN_PRIO, vlan->tcfv_push_prio) |
^~~~~~~~~~
>> drivers/net/ethernet/netronome/nfp/flower/action.c:70:41: error: 'struct tcf_vlan' has no member named 'tcfv_push_prio'
FIELD_PREP(NFP_FL_PUSH_VLAN_PRIO, vlan->tcfv_push_prio) |
^
include/linux/compiler.h:553:19: note: in definition of macro '__compiletime_assert'
bool __cond = !(condition); \
^~~~~~~~~
include/linux/compiler.h:576:2: note: in expansion of macro '_compiletime_assert'
_compiletime_assert(condition, msg, __compiletime_assert_, __LINE__)
^~~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:46:37: note: in expansion of macro 'compiletime_assert'
#define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
^~~~~~~~~~~~~~~~~~
include/linux/bitfield.h:56:3: note: in expansion of macro 'BUILD_BUG_ON_MSG'
BUILD_BUG_ON_MSG(__builtin_constant_p(_val) ? \
^~~~~~~~~~~~~~~~
include/linux/bitfield.h:88:3: note: in expansion of macro '__BF_FIELD_CHECK'
__BF_FIELD_CHECK(_mask, 0ULL, _val, "FIELD_PREP: "); \
^~~~~~~~~~~~~~~~
drivers/net/ethernet/netronome/nfp/flower/action.c:70:3: note: in expansion of macro 'FIELD_PREP'
FIELD_PREP(NFP_FL_PUSH_VLAN_PRIO, vlan->tcfv_push_prio) |
^~~~~~~~~~
In file included from drivers/net/ethernet/netronome/nfp/flower/action.c:34:0:
>> drivers/net/ethernet/netronome/nfp/flower/action.c:70:41: error: 'struct tcf_vlan' has no member named 'tcfv_push_prio'
FIELD_PREP(NFP_FL_PUSH_VLAN_PRIO, vlan->tcfv_push_prio) |
^
include/linux/bitfield.h:89:20: note: in definition of macro 'FIELD_PREP'
((typeof(_mask))(_val) << __bf_shf(_mask)) & (_mask); \
^~~~
In file included from include/asm-generic/bug.h:4:0,
from arch/ia64/include/asm/bug.h:12,
from include/linux/bug.h:4,
from include/linux/bitfield.h:18,
from drivers/net/ethernet/netronome/nfp/flower/action.c:34:
>> drivers/net/ethernet/netronome/nfp/flower/action.c:71:40: error: 'struct tcf_vlan' has no member named 'tcfv_push_vid'
FIELD_PREP(NFP_FL_PUSH_VLAN_VID, vlan->tcfv_push_vid) |
^
include/linux/compiler.h:553:19: note: in definition of macro '__compiletime_assert'
bool __cond = !(condition); \
^~~~~~~~~
include/linux/compiler.h:576:2: note: in expansion of macro '_compiletime_assert'
_compiletime_assert(condition, msg, __compiletime_assert_, __LINE__)
^~~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:46:37: note: in expansion of macro 'compiletime_assert'
#define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
^~~~~~~~~~~~~~~~~~
include/linux/bitfield.h:56:3: note: in expansion of macro 'BUILD_BUG_ON_MSG'
BUILD_BUG_ON_MSG(__builtin_constant_p(_val) ? \
^~~~~~~~~~~~~~~~
include/linux/bitfield.h:88:3: note: in expansion of macro '__BF_FIELD_CHECK'
__BF_FIELD_CHECK(_mask, 0ULL, _val, "FIELD_PREP: "); \
^~~~~~~~~~~~~~~~
drivers/net/ethernet/netronome/nfp/flower/action.c:71:3: note: in expansion of macro 'FIELD_PREP'
FIELD_PREP(NFP_FL_PUSH_VLAN_VID, vlan->tcfv_push_vid) |
^~~~~~~~~~
>> drivers/net/ethernet/netronome/nfp/flower/action.c:71:40: error: 'struct tcf_vlan' has no member named 'tcfv_push_vid'
FIELD_PREP(NFP_FL_PUSH_VLAN_VID, vlan->tcfv_push_vid) |
^
include/linux/compiler.h:553:19: note: in definition of macro '__compiletime_assert'
bool __cond = !(condition); \
^~~~~~~~~
include/linux/compiler.h:576:2: note: in expansion of macro '_compiletime_assert'
_compiletime_assert(condition, msg, __compiletime_assert_, __LINE__)
^~~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:46:37: note: in expansion of macro 'compiletime_assert'
#define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
^~~~~~~~~~~~~~~~~~
include/linux/bitfield.h:56:3: note: in expansion of macro 'BUILD_BUG_ON_MSG'
BUILD_BUG_ON_MSG(__builtin_constant_p(_val) ? \
^~~~~~~~~~~~~~~~
include/linux/bitfield.h:88:3: note: in expansion of macro '__BF_FIELD_CHECK'
__BF_FIELD_CHECK(_mask, 0ULL, _val, "FIELD_PREP: "); \
^~~~~~~~~~~~~~~~
drivers/net/ethernet/netronome/nfp/flower/action.c:71:3: note: in expansion of macro 'FIELD_PREP'
FIELD_PREP(NFP_FL_PUSH_VLAN_VID, vlan->tcfv_push_vid) |
^~~~~~~~~~
In file included from drivers/net/ethernet/netronome/nfp/flower/action.c:34:0:
>> drivers/net/ethernet/netronome/nfp/flower/action.c:71:40: error: 'struct tcf_vlan' has no member named 'tcfv_push_vid'
FIELD_PREP(NFP_FL_PUSH_VLAN_VID, vlan->tcfv_push_vid) |
^
include/linux/bitfield.h:89:20: note: in definition of macro 'FIELD_PREP'
((typeof(_mask))(_val) << __bf_shf(_mask)) & (_mask); \
^~~~
vim +70 drivers/net/ethernet/netronome/nfp/flower/action.c
1a1e586f Pieter Jansen van Vuuren 2017-06-29 @34 #include <linux/bitfield.h>
1a1e586f Pieter Jansen van Vuuren 2017-06-29 35 #include <net/pkt_cls.h>
1a1e586f Pieter Jansen van Vuuren 2017-06-29 36 #include <net/switchdev.h>
1a1e586f Pieter Jansen van Vuuren 2017-06-29 37 #include <net/tc_act/tc_gact.h>
1a1e586f Pieter Jansen van Vuuren 2017-06-29 38 #include <net/tc_act/tc_mirred.h>
da83d8fe Pieter Jansen van Vuuren 2017-10-06 39 #include <net/tc_act/tc_pedit.h>
1a1e586f Pieter Jansen van Vuuren 2017-06-29 40 #include <net/tc_act/tc_vlan.h>
b27d6a95 John Hurley 2017-09-25 41 #include <net/tc_act/tc_tunnel_key.h>
1a1e586f Pieter Jansen van Vuuren 2017-06-29 42
1a1e586f Pieter Jansen van Vuuren 2017-06-29 43 #include "cmsg.h"
1a1e586f Pieter Jansen van Vuuren 2017-06-29 44 #include "main.h"
1a1e586f Pieter Jansen van Vuuren 2017-06-29 45 #include "../nfp_net_repr.h"
1a1e586f Pieter Jansen van Vuuren 2017-06-29 46
1a1e586f Pieter Jansen van Vuuren 2017-06-29 47 static void nfp_fl_pop_vlan(struct nfp_fl_pop_vlan *pop_vlan)
1a1e586f Pieter Jansen van Vuuren 2017-06-29 48 {
1a1e586f Pieter Jansen van Vuuren 2017-06-29 49 size_t act_size = sizeof(struct nfp_fl_pop_vlan);
1a1e586f Pieter Jansen van Vuuren 2017-06-29 50
62d3f60b Pieter Jansen van Vuuren 2017-10-20 51 pop_vlan->head.jump_id = NFP_FL_ACTION_OPCODE_POP_VLAN;
62d3f60b Pieter Jansen van Vuuren 2017-10-20 52 pop_vlan->head.len_lw = act_size >> NFP_FL_LW_SIZ;
1a1e586f Pieter Jansen van Vuuren 2017-06-29 53 pop_vlan->reserved = 0;
1a1e586f Pieter Jansen van Vuuren 2017-06-29 54 }
1a1e586f Pieter Jansen van Vuuren 2017-06-29 55
1a1e586f Pieter Jansen van Vuuren 2017-06-29 56 static void
1a1e586f Pieter Jansen van Vuuren 2017-06-29 57 nfp_fl_push_vlan(struct nfp_fl_push_vlan *push_vlan,
1a1e586f Pieter Jansen van Vuuren 2017-06-29 58 const struct tc_action *action)
1a1e586f Pieter Jansen van Vuuren 2017-06-29 59 {
1a1e586f Pieter Jansen van Vuuren 2017-06-29 60 size_t act_size = sizeof(struct nfp_fl_push_vlan);
1a1e586f Pieter Jansen van Vuuren 2017-06-29 61 struct tcf_vlan *vlan = to_vlan(action);
1a1e586f Pieter Jansen van Vuuren 2017-06-29 62 u16 tmp_push_vlan_tci;
1a1e586f Pieter Jansen van Vuuren 2017-06-29 63
62d3f60b Pieter Jansen van Vuuren 2017-10-20 64 push_vlan->head.jump_id = NFP_FL_ACTION_OPCODE_PUSH_VLAN;
62d3f60b Pieter Jansen van Vuuren 2017-10-20 65 push_vlan->head.len_lw = act_size >> NFP_FL_LW_SIZ;
1a1e586f Pieter Jansen van Vuuren 2017-06-29 66 push_vlan->reserved = 0;
1a1e586f Pieter Jansen van Vuuren 2017-06-29 67 push_vlan->vlan_tpid = tcf_vlan_push_proto(action);
1a1e586f Pieter Jansen van Vuuren 2017-06-29 68
1a1e586f Pieter Jansen van Vuuren 2017-06-29 69 tmp_push_vlan_tci =
1a1e586f Pieter Jansen van Vuuren 2017-06-29 @70 FIELD_PREP(NFP_FL_PUSH_VLAN_PRIO, vlan->tcfv_push_prio) |
1a1e586f Pieter Jansen van Vuuren 2017-06-29 @71 FIELD_PREP(NFP_FL_PUSH_VLAN_VID, vlan->tcfv_push_vid) |
1a1e586f Pieter Jansen van Vuuren 2017-06-29 72 NFP_FL_PUSH_VLAN_CFI;
1a1e586f Pieter Jansen van Vuuren 2017-06-29 73 push_vlan->vlan_tci = cpu_to_be16(tmp_push_vlan_tci);
1a1e586f Pieter Jansen van Vuuren 2017-06-29 74 }
1a1e586f Pieter Jansen van Vuuren 2017-06-29 75
:::::: The code at line 70 was first introduced by commit
:::::: 1a1e586f54bfe54a0ba7ea0ac9b8c7b1d3e655f6 nfp: add basic action capabilities to flower offloads
:::::: TO: Pieter Jansen van Vuuren <pieter.jansenvanvuuren@...ronome.com>
:::::: CC: David S. Miller <davem@...emloft.net>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
Download attachment ".config.gz" of type "application/gzip" (48838 bytes)
Powered by blists - more mailing lists