netdev - Re: [PATCH V2 net] tuntap: properly align skb->head before building skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20171028.190615.1780763141354795593.davem@redhat.com>
Date:   Sat, 28 Oct 2017 19:06:15 +0900 (KST)
From:   David Miller <davem@...hat.com>
To:     jasowang@...hat.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        dotweiba@...il.com, edumazet@...gle.com,
        willemdebruijn.kernel@...il.com, dvyukov@...gle.com,
        mark.rutland@....com
Subject: Re: [PATCH V2 net] tuntap: properly align skb->head before
 building skb

From: Jason Wang <jasowang@...hat.com>
Date: Fri, 27 Oct 2017 11:05:44 +0800

> An unaligned alloc_frag->offset caused by previous allocation will
> result an unaligned skb->head. This will lead unaligned
> skb_shared_info and then unaligned dataref which requires to be
> aligned for accessing on some architecture. Fix this by aligning
> alloc_frag->offset before the frag refilling.
> 
> Fixes: 0bbd7dad34f8 ("tun: make tun_build_skb() thread safe")
> Cc: Eric Dumazet <edumazet@...gle.com>
> Cc: Willem de Bruijn <willemdebruijn.kernel@...il.com>
> Cc: Wei Wei <dotweiba@...il.com>
> Cc: Dmitry Vyukov <dvyukov@...gle.com>
> Cc: Mark Rutland <mark.rutland@....com>
> Reported-by: Wei Wei <dotweiba@...il.com>
> Signed-off-by: Jason Wang <jasowang@...hat.com>

Applied and queued up for -stable, thanks Jason.