netdev - Re: [PATCH net-next] ipv6: prevent user from adding cached routes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171029.121954.2114628342717563035.davem@davemloft.net>
Date:   Sun, 29 Oct 2017 12:19:54 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     weiwan@...gle.com
Cc:     netdev@...r.kernel.org, edumazet@...gle.com, kafai@...com
Subject: Re: [PATCH net-next] ipv6: prevent user from adding cached routes

From: Wei Wang <weiwan@...gle.com>
Date: Fri, 27 Oct 2017 17:30:12 -0700

> From: Wei Wang <weiwan@...gle.com>
> 
> Cached routes should only be created by the system when receiving pmtu
> discovery or ip redirect msg. Users should not be allowed to create
> cached routes.
> 
> Furthermore, after the patch series to move cached routes into exception
> table, user added cached routes will trigger the following warning in
> fib6_add():
 ...
> So we fix this by failing the attemp to add cached routes from userspace
> with returning EINVAL error.
> 
> Fixes: 2b760fcf5cfb ("ipv6: hook up exception table to store dst cache")
> Signed-off-by: Wei Wang <weiwan@...gle.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied, thank you.