netdev - [PATCH net-next v3 0/2] Completed requested changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Sun, 29 Oct 2017 04:46:52 -0400
From:   Manish Kurup <kurup.manish@...il.com>
To:     jhs@...atatu.com, xiyou.wangcong@...il.com, jiri@...nulli.us,
        jakub.kicinski@...ronome.com, simon.horman@...ronome.com,
        pieter.jansenvanvuuren@...ronome.com, john.hurley@...ronome.com,
        oss-drivers@...ronome.com, davem@...emloft.net,
        netdev@...r.kernel.org
Cc:     aring@...atatu.com, mrv@...atatu.com, kurup.manish@...il.com,
        Manish Kurup <manish.kurup@...izon.com>
Subject: [PATCH net-next v3 0/2] Completed requested changes

Hi everyone,

The kbuild robot detected an issue with building the netronome drivers (flower
action). Fixed them to use the VLAN helper functions instead of dereferencing
the structure directly.

Could you please review?

Here're the changes:
v2: Fixed all helper functions to use RCU (rtnl_dereference) - Eric, Jamal
v2: Fixed indentation, extra line nits - Jamal, Jiri
v2: Moved rcu_head to the end of the struct - Jiri
v2: Re-formatted locals to reverse-christmas-tree - Jiri
v2: Removed mismatched spin_lock() - Cong
v2: Removed spin_lock_bh() in tcf_vlan_init, rtnl_dereference() should
    suffice - Cong, Jiri
v3: Fixed a build break issue with nxp flower action. Modified the NXP flower
    action code to use the VLAN helper functions instead of referencing the
    structure directly. Found by kbuild robot.

Acked-by: Jamal Hadi Salim <jhs@...atatu.com>
Acked-by: Jiri Pirko <jiri@...lanox.com>
Signed-off-by: Manish Kurup <manish.kurup@...izon.com>

Manish Kurup (2):
  net sched act_vlan: Change stats update to use per-core stats
  net sched act_vlan: VLAN action rewrite to use RCU lock/unlock and
    update

 drivers/net/ethernet/netronome/nfp/flower/action.c |  5 +-
 include/net/tc_act/tc_vlan.h                       | 46 +++++++++++---
 net/sched/act_vlan.c                               | 71 ++++++++++++++--------
 3 files changed, 84 insertions(+), 38 deletions(-)

-- 
2.7.4