netdev - Re: can: Use common error handling code in vxcan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a76159d3-650e-5c2e-0f4a-dca394350473@hartkopp.net>
Date:   Sun, 29 Oct 2017 11:51:48 +0100
From:   Oliver Hartkopp <socketcan@...tkopp.net>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>,
        linux-can@...r.kernel.org, netdev@...r.kernel.org
Cc:     Marc Kleine-Budde <mkl@...gutronix.de>,
        Wolfgang Grandegger <wg@...ndegger.com>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: can: Use common error handling code in vxcan_newlink()

Hi Markus,

this discussion went far beyond the original posted patch for vxcan.c

I would suggest you post your idea of the simplified error handling flow 
in vxcan.c just on linux-can ML (which is the right mailing list for CAN 
related stuff).

Thanks,
Oliver

On 10/28/2017 10:13 PM, SF Markus Elfring wrote:
>>> Are you interested in related adjustments for a bigger code base?
>>
>> No. Definitely not.
> 
> You might have noticed that I am proposing similar changes already
> for other software modules.   ;-)
> 
> 
>> If you aim for the the deletion of “ < 0” for all rtnl_configure_link() users
>> you would need to do this consistently.
> 
> How do you see the software situation around a function
> like “register_netdevice”?
> 
> Regards,
> Markus
>