[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <163c37d7aa5230112e1e332467090a92d5836332.1509307616.git.sbrivio@redhat.com>
Date: Sun, 29 Oct 2017 21:22:32 +0100
From: Stefano Brivio <sbrivio@...hat.com>
To: Stephen Hemminger <stephen@...workplumber.org>
Cc: netdev@...r.kernel.org, Phil Sutter <phil@....cc>
Subject: [iproute PATCH 1/3] ss: Remove useless width specifier in process context print
Both local address and service, and remote address and service
fields are already printed out in netlink_show_one() before we
start printing process context, by calling sock_addr_print()
twice.
At this point, sock_addr_print() has already forced the remote
service field to be 'serv_width' wide -- that is, 'serv_width'
width has already been consumed, before we print process
context.
Hence, it makes no sense to force the display width of process
context to be 'serv_width' wide again: previous prints have
filled up the line already. Remove the width specifier and
prefix with a space instead, to keep this consistent with fields
which are displayed after the first output line.
Signed-off-by: Stefano Brivio <sbrivio@...hat.com>
---
misc/ss.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/misc/ss.c b/misc/ss.c
index dfb438f9162c..fa026eb0934b 100644
--- a/misc/ss.c
+++ b/misc/ss.c
@@ -3594,10 +3594,10 @@ static int netlink_show_one(struct filter *f,
getpidcon(pid, &pid_context);
if (pid_context != NULL) {
- printf("proc_ctx=%-*s ", serv_width, pid_context);
+ printf(" proc_ctx=%s", pid_context);
free(pid_context);
} else {
- printf("proc_ctx=%-*s ", serv_width, "unavailable");
+ printf(" proc_ctx=unavailable");
}
}
--
2.9.4
Powered by blists - more mailing lists