netdev - Re: [jkirsher/next-queue PATCH v5 0/6] tc-flower based cloud filters in i40e

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4bef6410-2849-859a-596c-4e90adf10aa8@oracle.com>
Date:   Mon, 30 Oct 2017 10:58:42 -0700
From:   Shannon Nelson <shannon.nelson@...cle.com>
To:     Amritha Nambiar <amritha.nambiar@...el.com>,
        intel-wired-lan@...ts.osuosl.org, jeffrey.t.kirsher@...el.com
Cc:     alexander.h.duyck@...el.com, jiri@...nulli.us,
        netdev@...r.kernel.org, jhs@...atatu.com,
        alexander.duyck@...il.com, xiyou.wangcong@...il.com
Subject: Re: [jkirsher/next-queue PATCH v5 0/6] tc-flower based cloud filters
 in i40e

On 10/27/2017 2:35 AM, Amritha Nambiar wrote:
> This patch series enables configuring cloud filters in i40e
> using the tc-flower classifier. The classification function
> of the filter is to match a packet to a traffic class. cls_flower is
> extended to offload classid to hardware. Hardware traffic classes
> are identified using classid values reserved in the range :ffe0 - :ffef.
> 
> The cloud filters are added for a VSI and are cleaned up when
> the VSI is deleted. The filters that match on L4 ports needs
> enhanced admin queue functions with big buffer support for
> extended fields in cloud filter commands.
> 
> Example:
> # tc qdisc add dev eth0 ingress
> # ethtool -K eth0 hw-tc-offload on
> 
> Match Dst IPv4,Dst Port and route to TC1:
> # tc filter add dev eth0 protocol ip parent ffff: prio 1 flower\
>    dst_ip 192.168.1.1/32 ip_proto udp dst_port 12000\
>    skip_sw hw_tc 1
> 
> # tc filter show dev eth0 parent ffff:
> filter pref 1 flower chain 0
> filter pref 1 flower chain 0 handle 0x1 hw_tc 1
>    eth_type ipv4
>    ip_proto udp
>    dst_ip 192.168.1.1
>    dst_port 12000
>    skip_sw
>    in_hw
> 
> v5: Hardware traffic class based on reserved classid values.
> Changes to align with Jiri's filter-block series. i40e code
> cleanup based on Shannon's comments.
> 
> Authors:
> Amritha Nambiar <amritha.nambiar@...el.com>
> Kiran Patil <kiran.patil@...el.com>
> Anjali Singhai Jain <anjali.singhai@...el.com>
> Jingjing Wu <jingjing.wu@...el.com>


Acked-by: Shannon Nelson <shannon.nelson@...cle.com>

> 
> ---
> 
> Amritha Nambiar (6):
>        net: sched: Identify hardware traffic classes using classid
>        i40e: Map TCs with the VSI seids
>        i40e: Cloud filter mode for set_switch_config command
>        i40e: Admin queue definitions for cloud filters
>        i40e: Clean up of cloud filters
>        i40e: Enable cloud filters via tc-flower
> 
> 
>   drivers/net/ethernet/intel/i40e/i40e.h             |   62 +
>   drivers/net/ethernet/intel/i40e/i40e_adminq_cmd.h  |  140 +++
>   drivers/net/ethernet/intel/i40e/i40e_common.c      |  193 ++++
>   drivers/net/ethernet/intel/i40e/i40e_ethtool.c     |    2
>   drivers/net/ethernet/intel/i40e/i40e_main.c        |  985 +++++++++++++++++++-
>   drivers/net/ethernet/intel/i40e/i40e_prototype.h   |   18
>   drivers/net/ethernet/intel/i40e/i40e_type.h        |   10
>   .../net/ethernet/intel/i40evf/i40e_adminq_cmd.h    |  110 ++
>   include/net/pkt_cls.h                              |    1
>   include/net/sch_generic.h                          |    7
>   net/sched/cls_flower.c                             |    2
>   11 files changed, 1491 insertions(+), 39 deletions(-)
> 
> --
>