netdev - Re: [PATCH net-next] net: display hw address of source machine during ipv6 DAD failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2aa97226-9db7-e401-3e90-7c773e1e083b@gmail.com>
Date:   Mon, 30 Oct 2017 14:43:14 -0600
From:   David Ahern <dsahern@...il.com>
To:     Vishwanath Pai <vpai@...mai.com>, yoshfuji@...ux-ipv6.org,
        kuznet@....inr.ac.ru, davem@...emloft.net
Cc:     netdev@...r.kernel.org, ilubashe@...mai.com, pai.vishwain@...il.com
Subject: Re: [PATCH net-next] net: display hw address of source machine during
 ipv6 DAD failure

On 10/30/17 2:29 PM, Vishwanath Pai wrote:
> This patch updates the error messages displayed in kernel log to include
> hwaddress of the source machine that caused ipv6 duplicate address
> detection failures.
> 
> Examples:
> 
> a) When we receive a NA packet from another machine advertising our
> address:
> 
> ICMPv6: NA: 34:ab:cd:56:11:e8 advertised our address 2601::2bb4 on eth0!

your example above does not agree with the format below. You have the
compressed IPv6 address, yet the format ...

> 
> b) When we detect DAD failure during address assignment to an interface:
> 
> IPv6: eth0: IPv6 duplicate address 2601::2b78 used by 34:ab:cd:56:11:e8
> detected!
> 
> Suggested-by: Igor Lubashev <ilubashe@...mai.com>
> Signed-off-by: Vishwanath Pai <vpai@...mai.com>
> ---


> @@ -989,8 +990,8 @@ static void ndisc_recv_na(struct sk_buff *skb)
>  		 */
>  		if (skb->pkt_type != PACKET_LOOPBACK)
>  			ND_PRINTK(1, warn,
> -				  "NA: someone advertises our address %pI6 on %s!\n",
> -				  &ifp->addr, ifp->idev->dev->name);
> +				  "NA: %pM advertised our address %pI6 on %s!\n",

... is uncompressed. Please make that '%pI6c' instead of pI6 in the line
above


> +				  eth_hdr(skb)->h_source, &ifp->addr, ifp->idev->dev->name);
>  		in6_ifa_put(ifp);
>  		return;
>  	}