netdev - Re: [PATCH v2 net-next] net: display hw address of source machine during ipv6 DAD failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fb6999ed-0b8d-c55d-b0fb-78b61d4b1f9a@gmail.com>
Date:   Mon, 30 Oct 2017 17:44:21 -0600
From:   David Ahern <dsahern@...il.com>
To:     Vishwanath Pai <vpai@...mai.com>, yoshfuji@...ux-ipv6.org,
        kuznet@....inr.ac.ru, davem@...emloft.net
Cc:     netdev@...r.kernel.org, ilubashe@...mai.com, pai.vishwain@...il.com
Subject: Re: [PATCH v2 net-next] net: display hw address of source machine
 during ipv6 DAD failure

On 10/30/17 5:38 PM, Vishwanath Pai wrote:
> This patch updates the error messages displayed in kernel log to include
> hwaddress of the source machine that caused ipv6 duplicate address
> detection failures.
> 
> Examples:
> 
> a) When we receive a NA packet from another machine advertising our
> address:
> 
> ICMPv6: NA: 34:ab:cd:56:11:e8 advertised our address 2001:db8:: on eth0!
> 
> b) When we detect DAD failure during address assignment to an interface:
> 
> IPv6: eth0: IPv6 duplicate address 2001:db8:: used by 34:ab:cd:56:11:e8
> detected!
> 
> v2:
>     Changed %pI6 to %pI6c in ndisc_recv_na()
>     Chaged the v6 address in the commit message to 2001:db8::
> 
> Suggested-by: Igor Lubashev <ilubashe@...mai.com>
> Signed-off-by: Vishwanath Pai <vpai@...mai.com>
> ---
>  include/net/addrconf.h | 2 +-
>  net/ipv6/addrconf.c    | 6 +++---
>  net/ipv6/ndisc.c       | 9 +++++----
>  3 files changed, 9 insertions(+), 8 deletions(-)

LGTM

Acked-by: David Ahern <dsahern@...il.com>