netdev - RE: [PATCH net-next 1/1] forcedeth: replace pci_alloc_consistent with dma_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <063D6719AE5E284EB5DD2968C1650D6DD00A8ABC@AcuExch.aculab.com>
Date:   Mon, 30 Oct 2017 11:27:06 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Zhu Yanjun' <yanjun.zhu@...cle.com>,
        "keescook@...omium.org" <keescook@...omium.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH net-next 1/1] forcedeth: replace pci_alloc_consistent
 with dma_alloc_coherent

From: Zhu Yanjun
> Sent: 28 October 2017 13:26
> The functions pci_alloc_consistent is obsolete. So it is replaced
> with dma_alloc_coherent
...
> +			dma_free_coherent(&np->pci_dev->dev,
> +					  sizeof(struct ring_desc) *
> +					  (np->rx_ring_size +
> +					  np->tx_ring_size),
> +					  np->rx_ring.orig, np->ring_addr);
...

That can't possibly be the best way to split those long lines.

	David