netdev - RE: [PATCH] lan78xx: Use common error handling code in lan78xx_phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9235D6609DB808459E95D78E17F2E43D40B9D816@CHN-SV-EXMX02.mchp-main.com>
Date:   Mon, 30 Oct 2017 14:32:59 +0000
From:   <Woojung.Huh@...rochip.com>
To:     <elfring@...rs.sourceforge.net>, <netdev@...r.kernel.org>,
        <linux-usb@...r.kernel.org>, <UNGLinuxDriver@...rochip.com>
CC:     <linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org>
Subject: RE: [PATCH] lan78xx: Use common error handling code in
 lan78xx_phy_init()

> From: SF Markus Elfring [mailto:elfring@...rs.sourceforge.net]
> Sent: Saturday, October 28, 2017 4:57 PM
> To: netdev@...r.kernel.org; linux-usb@...r.kernel.org; UNGLinuxDriver;
> Woojung Huh - C21699
> Cc: LKML; kernel-janitors@...r.kernel.org
> Subject: [PATCH] lan78xx: Use common error handling code in
> lan78xx_phy_init()
> 
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Sat, 28 Oct 2017 22:42:52 +0200
> 
> * Add a jump target so that a specific error message is stored only once
>   at the end of this function implementation.
> 
> * Replace two calls of the function "netdev_err" by goto statements.
> 
> * Adjust two condition checks.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---

Reviewed-by: Woojung Huh <Woojung.Huh@...rochip.com>