netdev - RE: [PATCH net-next] net: dpaa: remove init which already done in per-cpu allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 30 Oct 2017 05:08:28 +0000
From:   Madalin-cristian Bucur <madalin.bucur@....com>
To:     yuan linyu <cugyly@....com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     "David S . Miller" <davem@...emloft.net>,
        yuan linyu <Linyu.Yuan@...atel-sbell.com.cn>
Subject: RE: [PATCH net-next] net: dpaa: remove init which already done in
 per-cpu allocation

Hi Yuan,

Can you please give more details about this change you are proposing?

Regards,
Madalin

> -----Original Message-----
> From: netdev-owner@...r.kernel.org [mailto:netdev-owner@...r.kernel.org]
> On Behalf Of yuan linyu
> Sent: Sunday, October 29, 2017 3:49 AM
> To: netdev@...r.kernel.org
> Cc: David S . Miller <davem@...emloft.net>; yuan linyu
> <Linyu.Yuan@...atel-sbell.com.cn>
> Subject: [PATCH net-next] net: dpaa: remove init which already done in
> per-cpu allocation
> 
> From: yuan linyu <Linyu.Yuan@...atel-sbell.com.cn>
> 
> Signed-off-by: yuan linyu <Linyu.Yuan@...atel-sbell.com.cn>
> ---
>  drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> index a8d0be8..1ccc316 100644
> --- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> @@ -2814,10 +2814,6 @@ static int dpaa_eth_probe(struct platform_device
> *pdev)
>  		err = -ENOMEM;
>  		goto free_dpaa_fqs;
>  	}
> -	for_each_possible_cpu(i) {
> -		percpu_priv = per_cpu_ptr(priv->percpu_priv, i);
> -		memset(percpu_priv, 0, sizeof(*percpu_priv));
> -	}
> 
>  	priv->num_tc = 1;
>  	netif_set_real_num_tx_queues(net_dev, priv->num_tc *
> DPAA_TC_TXQ_NUM);
> --
> 2.7.4
>