netdev - Re: [PATCH net-next v3 2/2] net sched act_vlan: VLAN action rewrite to use RCU lock/unlock and update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171031130645.07c58fdd@pieter-Netronome>
Date:   Tue, 31 Oct 2017 13:06:45 +0000
From:   Pieter Jansen van Vuuren <pieter.jansenvanvuuren@...ronome.com>
To:     Manish Kurup <kurup.manish@...il.com>
Cc:     jhs@...atatu.com, xiyou.wangcong@...il.com, jiri@...nulli.us,
        jakub.kicinski@...ronome.com, simon.horman@...ronome.com,
        john.hurley@...ronome.com, oss-drivers@...ronome.com,
        davem@...emloft.net, netdev@...r.kernel.org, aring@...atatu.com,
        mrv@...atatu.com, Manish Kurup <manish.kurup@...izon.com>
Subject: Re: [PATCH net-next v3 2/2] net sched act_vlan: VLAN action rewrite
 to use RCU lock/unlock and update

On Sun, 29 Oct 2017 04:47:54 -0400
Manish Kurup <kurup.manish@...il.com> wrote:

> Using a spinlock in the VLAN action causes performance issues when the VLAN
> action is used on multiple cores. Rewrote the VLAN action to use RCU read
> locking for reads and updates instead.
> Fixed nxp flower action to use VLAN helper functions instead of accessing the
> structure directly (build break error).
Thank you Manish. One minor nit, I think you meant nfp flower action...
Also is it possible to split this patch into 2 patches, it seems to do 2 things:
1. Update the VLAN action to use RCU.
2. Fix the nfp flower action to use the VLAN helper.

Can you please dump the build break error you are seeing here?
...