netdev - Re: [PATCH net-next] ppp: Destroy the mutex when cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171031154849.nzi2rtx33iteyhbj@alphalink.fr>
Date:   Tue, 31 Oct 2017 16:48:49 +0100
From:   Guillaume Nault <g.nault@...halink.fr>
To:     gfree.wind@....163.com
Cc:     paulus@...ba.org, davem@...emloft.net, linux-ppp@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next] ppp: Destroy the mutex when cleanup

On Tue, Oct 31, 2017 at 06:25:37PM +0800, gfree.wind@....163.com wrote:
> From: Gao Feng <gfree.wind@....163.com>
> 
> The mutex_destroy only makes sense when enable DEBUG_MUTEX. For the
> good readbility, it's better to invoke it in exit func when the init
> func invokes mutex_init.
> 
> Signed-off-by: Gao Feng <gfree.wind@....163.com>
> ---
>  drivers/net/ppp/ppp_generic.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ppp/ppp_generic.c b/drivers/net/ppp/ppp_generic.c
> index af7f93e..4489133 100644
> --- a/drivers/net/ppp/ppp_generic.c
> +++ b/drivers/net/ppp/ppp_generic.c
> @@ -960,6 +960,7 @@ static __net_exit void ppp_exit_net(struct net *net)
>  	unregister_netdevice_many(&list);
>  	rtnl_unlock();
>  
> +	mutex_destroy(&pn->all_ppp_mutex);
>  	idr_destroy(&pn->units_idr);
>  }
>  

Acked-by: Guillaume Nault <g.nault@...halink.fr>

Thanks!