netdev - Re: [iproute PATCH 3/3] ss: Fix width calculations when Netid or State columns are missing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171031175506.6a7ff560@shemminger-XPS-13-9360>
Date:   Tue, 31 Oct 2017 17:55:06 +0100
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Stefano Brivio <sbrivio@...hat.com>
Cc:     netdev@...r.kernel.org, Phil Sutter <phil@....cc>
Subject: Re: [iproute PATCH 3/3] ss: Fix width calculations when Netid or
 State columns are missing

On Sun, 29 Oct 2017 21:22:34 +0100
Stefano Brivio <sbrivio@...hat.com> wrote:

> +	addrp_width -= netid_width + 1 * !!netid_width;
> +	addrp_width -= state_width + 1 * !!state_width;

Doing !! here is being too bit tricky for code that is not performance sensitive.
Just use an if statement or ? :

> @@ -4373,6 +4374,8 @@ int main(int argc, char *argv[])
>  			netid_width++;
>  		else if (state_width)
>  			state_width++;
> +		else
> +			odd_width_pad=" ";

Missing whitespace.