netdev - Re: [PATCH iproute2 3/3] xfrm_{state,policy}: Allow to deleteall polices/states with marks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171031181359.5b868f1a@shemminger-XPS-13-9360>
Date:   Tue, 31 Oct 2017 18:13:59 +0100
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Thomas Egerer <thomas.egerer@...unet.com>
Cc:     <netdev@...r.kernel.org>
Subject: Re: [PATCH iproute2 3/3] xfrm_{state,policy}: Allow to deleteall
 polices/states with marks

On Mon, 30 Oct 2017 19:11:46 +0100
Thomas Egerer <thomas.egerer@...unet.com> wrote:

>  
> +	if (tb[XFRMA_MARK]) {
> +		int r = addattr_l(new_n, xb->size, XFRMA_MARK,
> +				(void *)RTA_DATA(tb[XFRMA_MARK]), tb[XFRMA_MARK]->rta_len);

Since addattr_l already uses const void * for the attribute argument,
the cast here is unnecessary. Also try and break long lines if possible.

Also, you should probably be using RTA_PAYLOAD() rather than dereferncing rta_len
here.