netdev - Re: [PATCH iproute2 1/1] ip netns: use strtol() instead of atoi()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <85efpjfb7n.fsf@mojatatu.com>
Date:   Tue, 31 Oct 2017 14:01:32 -0400
From:   Roman Mashak <mrv@...atatu.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     netdev@...r.kernel.org, jhs@...atatu.com
Subject: Re: [PATCH iproute2 1/1] ip netns: use strtol() instead of atoi()

Stephen Hemminger <stephen@...workplumber.org> writes:

> On Fri, 27 Oct 2017 12:55:27 -0400
> Roman Mashak <mrv@...atatu.com> wrote:
>
>> Use strtol-based API to parse and validate integer input; atoi() does not detect
>> errors and may yield undefined behaviour if result can't be represented.
>> 
>> Signed-off-by: Roman Mashak <mrv@...atatu.com>
>
> Since network namespace is really an unsigned value, shouldn't it be
> using get_unsigned?

Agree, I will resend v2.