netdev - RE: [PATCH V2 net-next 1/2] liquidio: switchdev support for LiquidIO NIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM3PR07MB215455E6D8BD6A802A8289FBE15E0@DM3PR07MB2154.namprd07.prod.outlook.com>
Date:   Tue, 31 Oct 2017 19:32:01 +0000
From:   "Guvva, Vijaya" <Vijaya.Guvva@...ium.com>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>,
        "Manlunas, Felix" <Felix.Manlunas@...ium.com>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Vatsavayi, Raghu" <Raghu.Vatsavayi@...ium.com>,
        "Chickles, Derek" <Derek.Chickles@...ium.com>,
        "Burla, Satananda" <Satananda.Burla@...ium.com>
Subject: RE: [PATCH V2 net-next 1/2] liquidio: switchdev support for LiquidIO
 NIC

Thanks Jakub for reviewing the changes.

> SWITCHDEV_ATTR_ID_PORT_PARENT_ID is generally used to determine
> whether two ports belong to the same switch.  Do you not want to support rules
> which redirect packets from one PF (and it's VFs) to the other?
> 
We would be presenting each PF as a separate switch in switchdev model.
So, will be returning separate switchID for each PF.

> Also if you plug two cards into one system, the above will make you offload
> redirect between the cards.  Is that what you want?  Commonly the MAC
> address of the first port or serial number would be used here to make sure IDs
> are unique for each device.
This was done to have static UDEV rules which works on all liquidIO devices. We will resubmit patches for using mac address as switchID.

Thanks,
Vijay