netdev - Re: [PATCH] net: macb: remove redundant assignment to variable work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 01 Nov 2017 10:08:07 +0100
From:   Alexander Dahl <ada@...rsis.com>
To:     Colin King <colin.king@...onical.com>
Cc:     Nicolas Ferre <nicolas.ferre@...rochip.com>,
        netdev@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: macb: remove redundant assignment to variable work_done

Hei hei,

Am Dienstag, 31. Oktober 2017, 14:23:24 CET schrieb Colin King:
> --- a/drivers/net/ethernet/cadence/macb_main.c
> +++ b/drivers/net/ethernet/cadence/macb_main.c
> @@ -1218,8 +1218,6 @@ static int macb_poll(struct napi_struct *napi, int
> budget) status = macb_readl(bp, RSR);
>  	macb_writel(bp, RSR, status);
> 
> -	work_done = 0;
> -
>  	netdev_vdbg(bp->dev, "poll: status = %08lx, budget = %d\n",
>  		    (unsigned long)status, budget);

Looks reasonable, when looking at the surrounding code.

Applied this on top of 4.14-rc7 and tested it on an at91sam9g20 based 
platform.

Tested-by: Alexander Dahl <ada@...rsis.com>

Greets
Alex