netdev - Re: [PATCH net-next v2] ipv4: fix validate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 01 Nov 2017 21:27:05 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     pabeni@...hat.com
Cc:     netdev@...r.kernel.org, dsahern@...il.com,
        hannes@...essinduktion.org
Subject: Re: [PATCH net-next v2] ipv4: fix validate_source for VRF setup

From: Paolo Abeni <pabeni@...hat.com>
Date: Tue, 31 Oct 2017 14:32:38 +0100

> David reported breakages of VRF scenarios due to the
> commit 6e617de84e87 ("net: avoid a full fib lookup when rp_filter is
> disabled."): the local addresses based test is too strict when VRFs
> are in place.
> 
> With this change we fall-back to a full lookup when custom fib rules
> are in place; so that we address the VRF use case and possibly other
> similar issues in non trivial setups.
> 
> v1 -> v2:
>  - fix build breakage when CONFIG_IP_MULTIPLE_TABLES is not defined,
>    reported by the kbuild test robot
> 
> Reported-by: David Ahern <dsahern@...il.com>
> Fixes: 6e617de84e87 ("net: avoid a full fib lookup when rp_filter is disabled.")
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>

Applied.