netdev - Re: [PATCH] net: thunderx: remove a couple of redundant assignments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171101.213046.1800118728866748105.davem@davemloft.net>
Date:   Wed, 01 Nov 2017 21:30:46 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     colin.king@...onical.com
Cc:     sgoutham@...ium.com, rric@...nel.org,
        linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: thunderx: remove a couple of redundant assignments

From: Colin King <colin.king@...onical.com>
Date: Tue, 31 Oct 2017 14:37:55 +0000

> From: Colin Ian King <colin.king@...onical.com>
> 
> The assignment to pointer msg is redundant as it is never read, so
> remove msg.  Also remove the first assignment to qset as this is not
> read before the next re-assignment of a new value to qset in the
> for-loop. Cleans up two clang warnings:
> 
> drivers/net/ethernet/cavium/thunder/nic_main.c:589:2: warning: Value
> stored to 'msg' is never read
> drivers/net/ethernet/cavium/thunder/nic_main.c:611:2: warning: Value
> stored to 'qset' is never read
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Applied.