netdev - Re: [PATCH iproute2] Add "show" subcommand to "ip fou"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171101220333.5f73760f@shemminger-XPS-13-9360>
Date:   Wed, 1 Nov 2017 22:03:33 +0100
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Greg Greenway <ggreenway@...le.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH iproute2] Add "show" subcommand to "ip fou"

On Tue, 31 Oct 2017 13:00:47 -0700
Greg Greenway <ggreenway@...le.com> wrote:

> +	if (tb[FOU_ATTR_AF]) {
> +		family = rta_getattr_u8(tb[FOU_ATTR_AF]);
> +		if (family == AF_INET)
> +			family_str = "AF_INET";
> +		else if (family == AF_INET6)
> +			family_str = "AF_INET6";
> +		else
> +			family_str = "unknown";
> +		fprintf(fp, "af %s ", family_str);

The unwritten rule for ip commands is that the show function
must format the output with same command syntax as the other commands set/add/delete.
Since there is no "af AF_INET" option to ip fou, this breaks that convention.
Either ignore the address family, change the add command, or output with same
syntax (-6); preferably the latter.