netdev - Re: [PATCH net-next] tc-testing: split config file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20171101.110623.348780136039045689.davem@davemloft.net>
Date:   Wed, 01 Nov 2017 11:06:23 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     bjb@...atatu.com
Cc:     jhs@...atatu.com, xiyou.wangcong@...il.com, jiri@...nulli.us,
        chrism@...lanox.com, lucasb@...atatu.com, aring@...atatu.com,
        mrv@...atatu.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] tc-testing: split config file

From: "Brenda J. Butler" <bjb@...atatu.com>
Date: Tue, 31 Oct 2017 14:27:28 -0400

> Move the config customization into a site-local file
> tdc_config_local.py, so that updates of the tdc test
> software does not require hand-editing of the config.
> This patch includes a template for the site-local
> customization file.
> 
> In addition, this makes it easy to revert to a stock
> tdc environment for testing the test framework and/or
> the core tests.
> 
> Also it makes it harder for any custom config to be
> submitted back to the kernel tdc.
> 
> Signed-off-by: Brenda J. Butler <bjb@...atatu.com>

Please always remove trailing empty lines in files, GIT even warns
about this when one tries to apply the patch:

> @@ -17,3 +17,17 @@ NAMES = {
>            # Name of the namespace to use
>            'NS': 'tcut'
>          }
> +
 ...
> +# example adding values to ENVIR, without editing tdc_config.py
> +ENVIR['VALGRIND_LIB'] = '/usr/lib/valgrind'
> +ENVIR['VALGRIND_BIN'] = '/usr/bin/valgrind'
> +ENVIR['VGDB_BIN'] = '/usr/bin/vgdb'
> +

I fixed it up this time, but please be mindful of this in the future.

Thanks.