netdev - Re: [PATCH net] net: phy: marvell: Only configure RGMII delays when using RGMII

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171101.112657.673743512067444733.davem@davemloft.net>
Date:   Wed, 01 Nov 2017 11:26:57 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     andrew@...n.ch
Cc:     aaro.koskinen@....fi, netdev@...r.kernel.org
Subject: Re: [PATCH net] net: phy: marvell: Only configure RGMII delays
 when using RGMII

From: Andrew Lunn <andrew@...n.ch>
Date: Tue, 31 Oct 2017 20:31:28 +0100

> The fix 5987feb38aa5 ("net: phy: marvell: logical vs bitwise OR typo")
> uncovered another bug in the Marvell PHY driver, which broke the
> Marvell OpenRD platform. It relies on the bootloader configuring the
> RGMII delays and does not specify a phy-mode in its device tree.  The
> PHY driver should only configure RGMII delays if the phy mode
> indicates it is using RGMII. Without anything in device tree, the
> mv643xx Ethernet driver defaults to GMII.
> 
> Fixes: 5987feb38aa5 ("net: phy: marvell: logical vs bitwise OR typo")
> Signed-off-by: Andrew Lunn <andrew@...n.ch>

Applied, thanks Andrew.