netdev - Re: [PATCH net-next] net: qualcomm: rmnet: Support recycling frames to real device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171101.115522.243537601846810293.davem@davemloft.net>
Date:   Wed, 01 Nov 2017 11:55:22 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     subashab@...eaurora.org
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: qualcomm: rmnet: Support recycling
 frames to real device

From: Subash Abhinov Kasiviswanathan <subashab@...eaurora.org>
Date: Fri, 27 Oct 2017 14:30:08 -0600

> For deaggregation, the real device receives a large linear skb and
> passes it on to rmnet. rmnet creates new skbs from this large frame.
> 
> If the real device supports recycling, it does not need to allocate
> the large skbs during packet reception and can instead reuse them.
> 
> Signed-off-by: Subash Abhinov Kasiviswanathan <subashab@...eaurora.org>

I'm uncomfortable applying this until you also provide an example of
this skb->destructor mechanism actually being used in a driver.

Thank you.