netdev - Re: [PATCH net-next] net: dpaa: remove init which already done in per-cpu allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171101.120905.1863399513981852883.davem@davemloft.net>
Date:   Wed, 01 Nov 2017 12:09:05 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     cugyly@....com
Cc:     netdev@...r.kernel.org, Linyu.Yuan@...atel-sbell.com.cn
Subject: Re: [PATCH net-next] net: dpaa: remove init which already done in
 per-cpu allocation

From: yuan linyu <cugyly@....com>
Date: Sun, 29 Oct 2017 09:48:44 +0800

> From: yuan linyu <Linyu.Yuan@...atel-sbell.com.cn>
> 
> Signed-off-by: yuan linyu <Linyu.Yuan@...atel-sbell.com.cn>

Please compile test your patches and watch for warnings:

drivers/net/ethernet/freescale/dpaa/dpaa_eth.c: In function ‘dpaa_eth_probe’:
drivers/net/ethernet/freescale/dpaa/dpaa_eth.c:2671:27: warning: unused variable ‘percpu_priv’ [-Wunused-variable]
  struct dpaa_percpu_priv *percpu_priv;
                           ^~~~~~~~~~~
drivers/net/ethernet/freescale/dpaa/dpaa_eth.c: In function ‘dpaa_open’:
drivers/net/ethernet/freescale/dpaa/dpaa_eth.c:2497:9: warning: ‘err’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  return err;
         ^~~