netdev - Re: [PATCH] net: hns: set correct return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171101.121812.969003043230573555.davem@davemloft.net>
Date:   Wed, 01 Nov 2017 12:18:12 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     bianpan2016@....com
Cc:     yisen.zhuang@...wei.com, salil.mehta@...wei.com,
        lipeng321@...wei.com, linyunsheng@...wei.com, yankejian@...wei.com,
        tklauser@...tanz.ch, arnd@...db.de, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: hns: set correct return value

From: Pan Bian <bianpan2016@....com>
Date: Mon, 30 Oct 2017 16:50:01 +0800

> The function of_parse_phandle() returns a NULL pointer if it cannot
> resolve a phandle property to a device_node pointer. In function
> hns_nic_dev_probe(), its return value is passed to PTR_ERR to extract
> the error code. However, in this case, the extracted error code will
> always be zero, which is unexpected.
> 
> Signed-off-by: Pan Bian <bianpan2016@....com>

Applied.