netdev - Re: [PATCH] netfilter: ipvs: Convert timers to use timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGXu5jKi-yKO+QuvJ7kTJreZpvh_-Ozmbjr0e-HiXRXueT-RSg@mail.gmail.com>
Date:   Thu, 2 Nov 2017 15:11:54 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Simon Horman <horms@...ge.net.au>
Cc:     Julian Anastasov <ja@....bg>,
        "David S. Miller" <davem@...emloft.net>,
        Wensong Zhang <wensong@...ux-vs.org>,
        Pablo Neira Ayuso <pablo@...filter.org>,
        Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>,
        Florian Westphal <fw@...len.de>,
        Network Development <netdev@...r.kernel.org>,
        lvs-devel@...r.kernel.org, netfilter-devel@...r.kernel.org,
        coreteam@...filter.org, LKML <linux-kernel@...r.kernel.org>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] netfilter: ipvs: Convert timers to use timer_setup()

On Thu, Nov 2, 2017 at 7:42 AM, Simon Horman <horms@...ge.net.au> wrote:
> On Tue, Oct 24, 2017 at 10:07:03PM +0300, Julian Anastasov wrote:
>>
>>       Hello,
>>
>> On Tue, 24 Oct 2017, Kees Cook wrote:
>>
>> > In preparation for unconditionally passing the struct timer_list pointer to
>> > all timer callbacks, switch to using the new timer_setup() and from_timer()
>> > to pass the timer pointer explicitly.
>> >
>> > Cc: Wensong Zhang <wensong@...ux-vs.org>
>> > Cc: Simon Horman <horms@...ge.net.au>
>> > Cc: Julian Anastasov <ja@....bg>
>> > Cc: Pablo Neira Ayuso <pablo@...filter.org>
>> > Cc: Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>
>> > Cc: Florian Westphal <fw@...len.de>
>> > Cc: "David S. Miller" <davem@...emloft.net>
>> > Cc: netdev@...r.kernel.org
>> > Cc: lvs-devel@...r.kernel.org
>> > Cc: netfilter-devel@...r.kernel.org
>> > Cc: coreteam@...filter.org
>> > Signed-off-by: Kees Cook <keescook@...omium.org>
>>
>>       Looks good to me,
>>
>> Acked-by: Julian Anastasov <ja@....bg>
>
> Signed-off-by: Simon Horman <horms@...ge.net.au>
>
> Pablo, could you take this?

If it's helpful, we could take this via the timers tree. Either way. :) Thanks!

-Kees

-- 
Kees Cook
Pixel Security