netdev - Re: [patch net-next RFC 2/9] net_sch: mqprio: Change TC_SETUP_MQPRIO to TC_SETUP_QDISC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171102064822.GA2024@nanopsycho>
Date:   Thu, 2 Nov 2017 07:48:22 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Simon Horman <simon.horman@...ronome.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, nogahf@...lanox.com,
        jhs@...atatu.com, xiyou.wangcong@...il.com, mlxsw@...lanox.com,
        andrew@...n.ch, vivien.didelot@...oirfairelinux.com,
        f.fainelli@...il.com, michael.chan@...adcom.com,
        ganeshgr@...lsio.com, saeedm@...lanox.com, matanb@...lanox.com,
        leonro@...lanox.com, idosch@...lanox.com,
        jakub.kicinski@...ronome.com, pieter.jansenvanvuuren@...ronome.com,
        john.hurley@...ronome.com, alexander.h.duyck@...el.com,
        ogerlitz@...lanox.com, john.fastabend@...il.com
Subject: Re: [patch net-next RFC 2/9] net_sch: mqprio: Change TC_SETUP_MQPRIO
 to TC_SETUP_QDISC_MQPRIO

Wed, Nov 01, 2017 at 04:31:34PM CET, simon.horman@...ronome.com wrote:
>On Mon, Oct 30, 2017 at 09:56:06AM +0100, Jiri Pirko wrote:
>> From: Nogah Frankel <nogahf@...lanox.com>
>> 
>> Change TC_SETUP_MQPRIO to TC_SETUP_QDISC_MQPRIO to match the new
>> convention.
>
>Why is there a new convention? This churn in this and the following patch
>warrant some justification IMHO.

In the enum, there is CLS*, there should be also similar prefix for
QDICS group. That's it.