netdev - Re: [PATCH net-next] net: bridge: add notifications for the bridge dev on vlan change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171102.155417.1598178495654566553.davem@davemloft.net>
Date:   Thu, 02 Nov 2017 15:54:17 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     nikolay@...ulusnetworks.com
Cc:     netdev@...r.kernel.org, roopa@...ulusnetworks.com,
        bridge@...ts.linux-foundation.org, stephen@...workplumber.org
Subject: Re: [PATCH net-next] net: bridge: add notifications for the bridge
 dev on vlan change

From: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
Date: Wed,  1 Nov 2017 12:18:13 +0200

> Currently the bridge device doesn't generate any notifications upon vlan
> modifications on itself because it doesn't use the generic bridge
> notifications.
> With the recent changes we know if anything was modified in the vlan config
> thus we can generate a notification when necessary for the bridge device
> so add support to br_ifinfo_notify() similar to how other combined
> functions are done - if port is present it takes precedence, otherwise
> notify about the bridge. I've explicitly marked the locations where the
> notification should be always for the port by setting bridge to NULL.
> I've also taken the liberty to rearrange each modified function's local
> variables in reverse xmas tree as well.
> 
> Signed-off-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>

Applied.