netdev - Re: [PATCH] tcp_nv: fix division by zero in tcpnv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171102.161755.1469652396797608567.davem@davemloft.net>
Date:   Thu, 02 Nov 2017 16:17:55 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     khlebnikov@...dex-team.ru
Cc:     netdev@...r.kernel.org, brakmo@...com, kuznet@....inr.ac.ru,
        yoshfuji@...ux-ipv6.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tcp_nv: fix division by zero in tcpnv_acked()

From: Konstantin Khlebnikov <khlebnikov@...dex-team.ru>
Date: Wed, 01 Nov 2017 16:32:15 +0300

> Average RTT could become zero. This happened in real life at least twice.
> This patch treats zero as 1us.
> 
> Signed-off-by: Konstantin Khlebnikov <khlebnikov@...dex-team.ru>

Applied and queued up for -stable, thank you.

Indeed, as others have mentioned, a cheaper divide should be used
but that is a separate issue from this fix and therefore should be
done in a separate patch.

Thanks again.