netdev - Re: [PATCH v2 net-next] tcp: add tracepoint trace_tcp_retransmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171103.101322.1439534279100072262.davem@davemloft.net>
Date:   Fri, 03 Nov 2017 10:13:22 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     songliubraving@...com
Cc:     netdev@...r.kernel.org, alexei.starovoitov@...il.com,
        liu.song.a23@...il.com
Subject: Re: [PATCH v2 net-next] tcp: add tracepoint
 trace_tcp_retransmit_synack()

From: Song Liu <songliubraving@...com>
Date: Mon, 30 Oct 2017 14:41:35 -0700

> This tracepoint can be used to trace synack retransmits. It maintains
> pointer to struct request_sock.
> 
> We cannot simply reuse trace_tcp_retransmit_skb() here, because the
> sk here is the LISTEN socket. The IP addresses and ports should be
> extracted from struct request_sock.
> 
> Note that, like many other tracepoints, this patch uses IS_ENABLED
> in TP_fast_assign macro, which triggers sparse warning like:
> 
> ./include/trace/events/tcp.h:274:1: error: directive in argument list
> ./include/trace/events/tcp.h:281:1: error: directive in argument list
> 
> However, there is no good solution to avoid these warnings. To the
> best of our knowledge, these warnings are harmless.
> 
> Signed-off-by: Song Liu <songliubraving@...com>
> Acked-by: Alexei Starovoitov <ast@...nel.org>
> Acked-by: Martin KaFai Lau <kafai@...com>

Applied.