netdev - Re: [PATCH net] add support of IFF_XMIT_DST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1509673189.2849.39.camel@edumazet-glaptop3.roam.corp.google.com>
Date:   Thu, 02 Nov 2017 18:39:49 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Vadim Fedorenko <vfedorenko@...dex-team.ru>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Paweł Staszewski <pstaszewski@...are.pl>
Subject: Re: [PATCH net] add support of IFF_XMIT_DST_RELEASE bit in vlan

On Fri, 2017-11-03 at 01:39 +0300, Vadim Fedorenko wrote:

> Do you mean what happens with vlan device with real_dev is bonding ?
> 
> With patches:
> 1) A is added
>    bond_enslave()
>      bond_compute_features()
>              -> bond_dev IFF_XMIT_DST_RELEASE is not changed (set)
>        netdev_change_features()
>          vlan_device_event(event=NETDEV_FEAT_CHANGE)
>            vlan_transfer_features()
>              -> vlan_dev IFF_XMIT_DST_RELEASE is not changed (still set)
> Then B is added
>    bond_enslave()
>      bond_compute_features()
>              -> bond_dev IFF_XMIT_DST_RELEASE is changed (cleared)
>        netdev_change_features()
>          vlan_device_event(event=NETDEV_FEAT_CHANGE)
>            vlan_transfer_features()
>              -> vlan_dev IFF_XMIT_DST_RELEASE is changed (cleared)
> 
> 2) B is added
>    bond_enslave()
>      bond_compute_features()
>              -> bond_dev IFF_XMIT_DST_RELEASE is changed (cleared)
>        netdev_change_features()
>          vlan_device_event(event=NETDEV_FEAT_CHANGE)
>            vlan_transfer_features()
>              -> vlan_dev IFF_XMIT_DST_RELEASE is changed (cleared)
> Then A is added
>    bond_enslave()
>      bond_compute_features()
>              -> bond_dev IFF_XMIT_DST_RELEASE is not changed (cleared)
>        netdev_change_features()
>          vlan_device_event(event=NETDEV_FEAT_CHANGE)
>            vlan_transfer_features()
>              -> vlan_dev IFF_XMIT_DST_RELEASE is not changed (cleared).
> 
> Without patches:
> 1) A is added
>    bond_enslave()
>      bond_compute_features()
>              -> bond_dev IFF_XMIT_DST_RELEASE is not changed (set)
>        netdev_change_features()
>          vlan_device_event(event=NETDEV_FEAT_CHANGE)
>            vlan_transfer_features()
>               -> vlan_dev IFF_XMIT_DST_RELEASE is not changed (cleared)
> 
> Then B is added
>    bond_enslave()
>      bond_compute_features()
>               -> bond_dev IFF_XMIT_DST_RELEASE is changed (cleared)
>        netdev_change_features()
>          vlan_device_event(event=NETDEV_FEAT_CHANGE)
>            vlan_transfer_features()
>               -> vlan_dev IFF_XMIT_DST_RELEASE is not changed(cleared)
> 2) B is added
>    bond_enslave()
>      bond_compute_features()
>               -> bond_dev IFF_XMIT_DST_RELEASE is changed (cleared)
>        netdev_change_features()
>          vlan_device_event(event=NETDEV_FEAT_CHANGE)
>            vlan_transfer_features()
>               -> vlan_dev IFF_XMIT_DST_RELEASE is not changed(cleared)
> Then A is added
>    bond_enslave()
>      bond_compute_features()
>               -> bond_dev IFF_XMIT_DST_RELEASE is not changed (cleared)
>        netdev_change_features()
>          vlan_device_event(event=NETDEV_FEAT_CHANGE)
>            vlan_transfer_features()
>               -> vlan_dev IFF_XMIT_DST_RELEASE is not changed (cleared).
> 

Thanks for this investigation !

Reviewed-by: Eric Dumazet <edumazet@...gle.com>