netdev - Re: [patch net-next] net: sched: move block offload unbind after all chains are flushed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20171103.154744.1648531780926119509.davem@davemloft.net>
Date:   Fri, 03 Nov 2017 15:47:44 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     jiri@...nulli.us
Cc:     netdev@...r.kernel.org, jhs@...atatu.com, xiyou.wangcong@...il.com,
        mlxsw@...lanox.com, alexander.h.duyck@...el.com, kubakici@...pl
Subject: Re: [patch net-next] net: sched: move block offload unbind after
 all chains are flushed

From: Jiri Pirko <jiri@...nulli.us>
Date: Thu,  2 Nov 2017 15:07:01 +0100

> From: Jiri Pirko <jiri@...lanox.com>
> 
> Currently, the offload unbind is done before the chains are flushed.
> That causes driver to unregister block callback before it can get all
> the callback calls done during flush, leaving the offloaded tps inside
> the HW. So fix the order to prevent this situation and restore the
> original behaviour.
> 
> Reported-by: Alexander Duyck <alexander.duyck@...il.com>
> Reported-by: Jakub Kicinski <kubakici@...pl>
> Signed-off-by: Jiri Pirko <jiri@...lanox.com>

I'm pretty sure this was my fault during the merge, I had to pick
whether to do it before or after the offload unbind and I picked the
latter.

Applied, thank you.