netdev - Re: [Patch net-next] net_sched: check NULL in tcf_block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171103065619.GD2024@nanopsycho>
Date:   Fri, 3 Nov 2017 07:56:19 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Cong Wang <xiyou.wangcong@...il.com>
Cc:     netdev@...r.kernel.org, dave.taht@...il.com,
        Jiri Pirko <jiri@...lanox.com>
Subject: Re: [Patch net-next] net_sched: check NULL in tcf_block_put()

Fri, Nov 03, 2017 at 01:32:08AM CET, xiyou.wangcong@...il.com wrote:
>Callers of tcf_block_put() could pass NULL so
>we can't use block->q before checking if block is
>NULL or not.
>
>tcf_block_put_ext() callers are fine, it is always
>non-NULL.
>
>Fixes: 8c4083b30e56 ("net: sched: add block bind/unbind notif. and extended block_get/put")
>Reported-by: Dave Taht <dave.taht@...il.com>
>Cc: Jiri Pirko <jiri@...lanox.com>
>Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>

Reviewed-by: Jiri Pirko <jiri@...lanox.com>