netdev - Re: [PATCH net-next] tcp: tcp_fragment() should not assume rtx skbs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171103.160324.395984746958427451.davem@davemloft.net>
Date:   Fri, 03 Nov 2017 16:03:24 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     netdev@...r.kernel.org, ycheng@...gle.com, ncardwell@...gle.com,
        soheil@...gle.com, ast@...nel.org, priyarjha@...gle.com
Subject: Re: [PATCH net-next] tcp: tcp_fragment() should not assume rtx skbs

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 02 Nov 2017 18:10:03 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> While stress testing MTU probing, we had crashes in list_del() that we root-caused
> to the fact that tcp_fragment() is unconditionally inserting the freshly allocated
> skb into tsorted_sent_queue list.
> 
> But this list is supposed to contain skbs that were sent.
> This was mostly harmless until MTU probing was enabled.
> 
> Fortunately we can use the tcp_queue enum added later (but in same linux version)
> for rtx-rb-tree to fix the bug. 
> 
> Fixes: e2080072ed2d ("tcp: new list for sent but unacked skbs for RACK recovery")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied, thanks Eric.