netdev - Re: [net-next 06/12] net/mlx5e: Support DSCP trust state to Ethernet's IP packet on SQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ3xEMjfLLiEA4JJza4skyeq3-GV6=NMqqHmuOn0P+AB0pshvA@mail.gmail.com>
Date:   Sat, 4 Nov 2017 18:07:34 +0900
From:   Or Gerlitz <gerlitz.or@...il.com>
To:     Saeed Mahameed <saeedm@...lanox.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Linux Netdev List <netdev@...r.kernel.org>,
        Huy Nguyen <huyn@...lanox.com>
Subject: Re: [net-next 06/12] net/mlx5e: Support DSCP trust state to
 Ethernet's IP packet on SQ

On Sat, Nov 4, 2017 at 5:50 PM, Saeed Mahameed <saeedm@...lanox.com> wrote:
> From: Huy Nguyen <huyn@...lanox.com>
>
> If the port is in DSCP trust state, packets are placed in the right
> priority queue based on the dscp value. This is done by selecting
> the transmit queue based on the dscp of the skb.
>
> Until now select_queue honors priority only from the vlan header.
> However that is not sufficient in cases where port trust state is DSCP
> mode as packet might not even contain vlan header. Therefore if the port
> is in dscp trust state and vport's min inline mode is not NONE,
> copy the IP header to the eseg's inline header if the skb has it.
> This is done by changing the transmit queue sq's min inline mode to L3.
> Note that the min inline mode of sqs that belong to other features such
> as xdpsq, icosq are not modified.
>
> Signed-off-by: Huy Nguyen <huyn@...lanox.com>
> Reviewed-by: Parav Pandit <parav@...lanox.com>
> Signed-off-by: Saeed Mahameed <saeedm@...lanox.com>

Reviewed-by: Or Gerlitz <ogerlitz@...lanox.com>