netdev - Re: [PATCH] netfilter/ipvs: clear ipvs_property flag when SKB net namespace changed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171104.223822.848425746136000220.davem@davemloft.net>
Date:   Sat, 04 Nov 2017 22:38:22 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     horms@...ge.net.au
Cc:     ja@....bg, hustcat@...il.com, willemb@...gle.com,
        edumazet@...gle.com, johannes.berg@...el.com, dcaratti@...hat.com,
        pabeni@...hat.com, f.fainelli@...il.com, fw@...len.de,
        soheil@...gle.com, dwindsor@...il.com, elena.reshetova@...el.com,
        tom@...ntonium.net, Jason@...c4.com, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, chouryzhou@...il.com, wensong@...ux-vs.org,
        lvs-devel@...r.kernel.org
Subject: Re: [PATCH] netfilter/ipvs: clear ipvs_property flag when SKB net
 namespace changed

From: Simon Horman <horms@...ge.net.au>
Date: Thu, 2 Nov 2017 15:46:50 +0100

> On Sat, Oct 28, 2017 at 01:33:09PM +0300, Julian Anastasov wrote:
>> 
>> 	Hello,
>> 
>> On Thu, 26 Oct 2017, Ye Yin wrote:
>> 
>> > When run ipvs in two different network namespace at the same host, and one
>> > ipvs transport network traffic to the other network namespace ipvs.
>> > 'ipvs_property' flag will make the second ipvs take no effect. So we should
>> > clear 'ipvs_property' when SKB network namespace changed.
>> > 
>> > Signed-off-by: Ye Yin <hustcat@...il.com>
>> > Signed-off-by: Wei Zhou <chouryzhou@...il.com>
>> 
>> 	Patch looks good to me. ipvs_property was added long ago
>> but skb_scrub_packet() is more recent (3.11), so:
>> 
>> Fixes: 621e84d6f373 ("dev: introduce skb_scrub_packet()")
>> Signed-off-by: Julian Anastasov <ja@....bg>
>> 
>> 	I guess, DaveM can apply it directly as a bugfix
>> to the net tree.
> 
> Sounds like a good plan to me, Dave?
> 
> Signed-off-by: Simon Horman <horms@...ge.net.au>

Sure, applied and queued up for -stable, thanks!