netdev - Re: [PATCH] NFC: fix device-allocation error return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171105235414.GA27831@zurbaran.ger.intel.com>
Date:   Mon, 6 Nov 2017 00:54:14 +0100
From:   Samuel Ortiz <sameo@...ux.intel.com>
To:     Johan Hovold <johan@...nel.org>
Cc:     "David S. Miller" <davem@...emloft.net>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        Dan Carpenter <dan.carpenter@...cle.com>,
        stable <stable@...r.kernel.org>
Subject: Re: [PATCH] NFC: fix device-allocation error return

Hi Johan,

On Sun, Jul 09, 2017 at 01:08:58PM +0200, Johan Hovold wrote:
> A recent change fixing NFC device allocation itself introduced an
> error-handling bug by returning an error pointer in case device-id
> allocation failed. This is clearly broken as the callers still expected
> NULL to be returned on errors as detected by Dan's static checker.
> 
> Fix this up by returning NULL in the event that we've run out of memory
> when allocating a new device id.
> 
> Note that the offending commit is marked for stable (3.8) so this fix
> needs to be backported along with it.
> 
> Fixes: 20777bc57c34 ("NFC: fix broken device allocation")
> Cc: stable <stable@...r.kernel.org>	# 3.8
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Johan Hovold <johan@...nel.org>
> ---
>  net/nfc/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks for the fix.

Cheers,
Samuel.