netdev - [PATCH 02/21] ppp: exit_net cleanup checks added

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <eec31e0a-3b8b-6197-56bf-b436a6bace2e@virtuozzo.com>
Date:   Sun, 5 Nov 2017 12:59:14 +0300
From:   Vasily Averin <vvs@...tuozzo.com>
To:     netdev@...r.kernel.org
Cc:     linux-ppp@...r.kernel.org, Paul Mackerras <paulus@...ba.org>
Subject: [PATCH 02/21] ppp: exit_net cleanup checks added

Be sure that lists initialized in net_init hook were return to initial state

Signed-off-by: Vasily Averin <vvs@...tuozzo.com>
---
 drivers/net/ppp/ppp_generic.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/ppp/ppp_generic.c b/drivers/net/ppp/ppp_generic.c
index e365866..c9791bc 100644
--- a/drivers/net/ppp/ppp_generic.c
+++ b/drivers/net/ppp/ppp_generic.c
@@ -960,6 +960,10 @@ static __net_exit void ppp_exit_net(struct net *net)
 	rtnl_unlock();
 
 	idr_destroy(&pn->units_idr);
+	WARN(!list_empty(&pn->all_channels),
+	     "net %p exit: ppp all_channels list is not empty\n", net);
+	WARN(!list_empty(&pn->new_channels),
+	     "net %p exit: ppp new_channels list is not empty\n", net);
 }
 
 static struct pernet_operations ppp_net_ops = {
-- 
2.7.4