netdev - Re: [PATCH net-next] tcp: do not clear again skb->csum in tcp_init_nondata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171105.221554.777694016062806046.davem@davemloft.net>
Date:   Sun, 05 Nov 2017 22:15:54 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     netdev@...r.kernel.org, ncardwell@...gle.com
Subject: Re: [PATCH net-next] tcp: do not clear again skb->csum in
 tcp_init_nondata_skb()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Fri, 03 Nov 2017 06:18:59 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> tcp_init_nondata_skb() is fed with freshly allocated skbs.
> They already have a cleared csum field, no need to clear it again.
> 
> This is based on Neal review on commit 3b11775033dc ("tcp: do not mangle
> skb->cb[] in tcp_make_synack()"), noticing I did not clear skb->csum.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: Neal Cardwell <ncardwell@...gle.com>

Applied.