netdev - Re: [PATCH] net: usb: asix: fill null-ptr-deref in asix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAeHK+z9xWusLR6n_ooBdLeCQwzmLeMrbT+7cFm1PL1vuG4JMQ@mail.gmail.com>
Date:   Mon, 6 Nov 2017 13:30:33 +0100
From:   Andrey Konovalov <andreyknvl@...gle.com>
To:     Oliver Neukum <oneukum@...e.com>
Cc:     allan <allan@...x.com.tw>,
        Colin Ian King <colin.king@...onical.com>,
        "David S . Miller" <davem@...emloft.net>,
        Philippe Reynes <tremyfr@...il.com>,
        Greg Ungerer <gerg@...ux-m68k.org>,
        Dean Jenkins <Dean_Jenkins@...tor.com>,
        Peter Chen <peter.chen@....com>,
        LKML <linux-kernel@...r.kernel.org>,
        USB list <linux-usb@...r.kernel.org>,
        netdev <netdev@...r.kernel.org>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        Kostya Serebryany <kcc@...gle.com>
Subject: Re: [PATCH] net: usb: asix: fill null-ptr-deref in asix_suspend

On Mon, Nov 6, 2017 at 10:49 AM, Oliver Neukum <oneukum@...e.com> wrote:
> Am Donnerstag, den 02.11.2017, 21:26 +0100 schrieb Andrey Konovalov:
>> When asix_suspend() is called dev->driver_priv might not have been
>> assigned a value, so we need to check that it's not NULL.
>>
>> Found by syzkaller.
>
> Hi,

Hi Oliver,

>
> 1. if that happens on suspend, it will also happen on resume

Indeed, got crashes in asix_resume() tonight as well. Mailed v2.

> 2. Will a device work after that? The appropriate fix may be to wait
> until the device is properly initialized.

This shouldn't affect real devices as far as I understand. The crash
can be caused by a crafted malicious device.

Go ahead if you see a better way to fix this, my patch is more of a
hot fix trying to prevent the crashes.

Thanks!

>
>         Regards
>                 Oliver
>