netdev - Re: [PATCH] ipvs: Fix inappropriate output of procfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171106142647.GA8571@salvia>
Date:   Mon, 6 Nov 2017 15:26:47 +0100
From:   Pablo Neira Ayuso <pablo@...filter.org>
To:     Julian Anastasov <ja@....bg>
Cc:     KUWAZAWA Takuya <albatross0@...il.com>,
        Wensong Zhang <wensong@...ux-vs.org>,
        Simon Horman <horms@...ge.net.au>,
        Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>,
        Florian Westphal <fw@...len.de>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        lvs-devel@...r.kernel.org, netfilter-devel@...r.kernel.org,
        coreteam@...filter.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ipvs: Fix inappropriate output of procfs

On Sun, Oct 15, 2017 at 05:11:28PM +0300, Julian Anastasov wrote:
> On Sun, 15 Oct 2017, KUWAZAWA Takuya wrote:
> 
> > Information about ipvs in different network namespace can be seen via procfs.
> > 
> > How to reproduce:
> > 
> >   # ip netns add ns01
> >   # ip netns add ns02
> >   # ip netns exec ns01 ip a add dev lo 127.0.0.1/8
> >   # ip netns exec ns02 ip a add dev lo 127.0.0.1/8
> >   # ip netns exec ns01 ipvsadm -A -t 10.1.1.1:80
> >   # ip netns exec ns02 ipvsadm -A -t 10.1.1.2:80
> > 
> > The ipvsadm displays information about its own network namespace only.
> > 
> >   # ip netns exec ns01 ipvsadm -Ln
> >   IP Virtual Server version 1.2.1 (size=4096)
> >   Prot LocalAddress:Port Scheduler Flags
> >     -> RemoteAddress:Port           Forward Weight ActiveConn InActConn
> >   TCP  10.1.1.1:80 wlc
> > 
> >   # ip netns exec ns02 ipvsadm -Ln
> >   IP Virtual Server version 1.2.1 (size=4096)
> >   Prot LocalAddress:Port Scheduler Flags
> >     -> RemoteAddress:Port           Forward Weight ActiveConn InActConn
> >   TCP  10.1.1.2:80 wlc
> > 
> > But I can see information about other network namespace via procfs.
> > 
> >   # ip netns exec ns01 cat /proc/net/ip_vs
> >   IP Virtual Server version 1.2.1 (size=4096)
> >   Prot LocalAddress:Port Scheduler Flags
> >     -> RemoteAddress:Port Forward Weight ActiveConn InActConn
> >   TCP  0A010101:0050 wlc
> >   TCP  0A010102:0050 wlc
> > 
> >   # ip netns exec ns02 cat /proc/net/ip_vs
> >   IP Virtual Server version 1.2.1 (size=4096)
> >   Prot LocalAddress:Port Scheduler Flags
> >     -> RemoteAddress:Port Forward Weight ActiveConn InActConn
> >   TCP  0A010102:0050 wlc
> > 
> > Signed-off-by: KUWAZAWA Takuya <albatross0@...il.com>
> 
> 	Looks good to me
> 
> Acked-by: Julian Anastasov <ja@....bg>

Applied, thanks.