netdev - Re: [PATCH] ieee802154: mrf24j40: fix incorrect mask in mrf24j40

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4f966500-ec25-6390-6453-c037a05f028c@signal11.us>
Date:   Mon, 6 Nov 2017 09:36:01 -0500
From:   Alan Ott <alan@...nal11.us>
To:     Stefan Schmidt <stefan@....samsung.com>,
        "Gustavo A. R. Silva" <garsilva@...eddedor.com>,
        Alexander Aring <alex.aring@...il.com>
Cc:     linux-wpan@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Julia Lawall <julia.lawall@...6.fr>
Subject: Re: [PATCH] ieee802154: mrf24j40: fix incorrect mask in mrf24j40_stop

On 11/06/2017 06:13 AM, Stefan Schmidt wrote:
> Hello Alan.
>
> On 10/31/2017 07:31 AM, Gustavo A. R. Silva wrote:
>> It seems that this is a copy/paste error and the proper bit masking is:
>> BIT_TXNIE | BIT_RXIE
>>
>> This issue was detected with the help of Coccinelle.
>>
>> Reported-by: Julia Lawall <julia.lawall@...6.fr>
>> Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>
>> Fixes: 7d840545e5b9 ("mrf24j40: replace magic numbers")
>> ---
>>  drivers/net/ieee802154/mrf24j40.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ieee802154/mrf24j40.c b/drivers/net/ieee802154/mrf24j40.c
>> index ee7084b..cf4788d 100644
>> --- a/drivers/net/ieee802154/mrf24j40.c
>> +++ b/drivers/net/ieee802154/mrf24j40.c
>> @@ -635,7 +635,7 @@ static void mrf24j40_stop(struct ieee802154_hw *hw)
>>
>>  	/* Set TXNIE and RXIE. Disable Interrupts */
>>  	regmap_update_bits(devrec->regmap_short, REG_INTCON,
>> -			   BIT_TXNIE | BIT_TXNIE, BIT_TXNIE | BIT_TXNIE);
>> +			   BIT_TXNIE | BIT_RXIE, BIT_TXNIE | BIT_RXIE);
>>  }
>>
>>  static int mrf24j40_set_channel(struct ieee802154_hw *hw, u8 page, u8 channel)
>>
>
> Could you review this and give me your ack when you are happy so I can apply it to my tree?
>

Acked-by: Alan Ott <alan@...nal11.us>