netdev - Re: [PATCH net-next] net: dsa: lan9303: Drop port range check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4d340c8e-8155-1251-3ab1-76f4948d9f1b@egil-hjelmeland.no>
Date:   Mon, 6 Nov 2017 15:39:46 +0100
From:   Egil Hjelmeland <privat@...l-hjelmeland.no>
To:     andrew@...n.ch, vivien.didelot@...oirfairelinux.com,
        f.fainelli@...il.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: dsa: lan9303: Drop port range check

On 06. nov. 2017 15:19, Egil Hjelmeland wrote:
> Now that ds->num_ports is 3, there is no need to check range of "port"
> parameter.
> 
> +	lan9303_disable_processing_port(chip, port);
> +	lan9303_phy_write(ds, chip->phy_addr_sel_strap + port,
> +			  MII_BMCR, BMCR_PDOWN);
>   }

I see now that line breaking could be adjusted here. But I am going to 
touch that line in a upcomming patch about phy_addr_sel_strap. I
promise fix it then, making it to a one-liner.

>   
>   static int lan9303_port_bridge_join(struct dsa_switch *ds, int port,
> 

Egil