[<prev] [next>] [day] [month] [year] [list]
Message-ID: <20171106182512.68786484@pieter-Netronome>
Date: Mon, 6 Nov 2017 18:25:12 +0000
From: Pieter Jansen van Vuuren <pieter.jansenvanvuuren@...ronome.com>
To: Manish Kurup <kurup.manish@...il.com>
Cc: David Miller <davem@...emloft.net>,
Jamal Hadi Salim <jhs@...atatu.com>,
Cong Wang <xiyou.wangcong@...il.com>,
Jiri Pirko <jiri@...nulli.us>, jakub.kicinski@...ronome.com,
simon.horman@...ronome.com, john.hurley@...ronome.com,
Alexander Aring <aring@...atatu.com>,
Roman Mashak <mrv@...atatu.com>,
Manish Kurup <manish.kurup@...izon.com>,
netdev@...r.kernel.org, oss-drivers@...ronome.com
Subject: Re: [PATCH net-next v6 0/3] Incorporated all required changes
On Mon, 6 Nov 2017 11:52:37 -0500
Manish Kurup <kurup.manish@...il.com> wrote:
> Hi Dave,
>
> On Sun, Nov 5, 2017 at 8:08 AM, David Miller <davem@...emloft.net> wrote:
>
> > From: Manish Kurup <kurup.manish@...il.com>
> > Date: Fri, 3 Nov 2017 11:49:19 -0400
> >
> > > Modified the netronome drivers (flower action) to use the VLAN helper
> > > functions instead of dereferencing the structure directly. This is
> > > required for the VLAN action patch.
> > >
> > > Could you please review?
> >
> > Please use a more appropriate patch series header posting than this.
> >
> > This subject shall describe what the patch series is about, in much
> > the same style as a normal commit, using appropriate subsystem
> > prefixes and so on.
> >
> > The commit message body must describe what the patch series is doing,
> > how it is doing it, and why it is doing it that way.
> >
>
> Mistakenly unicasted my reply (below) to Dave.
>
> Currently, the body of the commit message describes what it is doing in
> each commit patch. Would you like me to add some detail to the
> description of each commit?
Hi Manish, Your patch series header is "Incorporated all required
changes", could you update this to something more descriptive?
Powered by blists - more mailing lists