netdev - Re: [PATCH net-next v6 2/3] nfp flower action: Modified to use VLAN helper functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171106183332.22348570@pieter-Netronome>
Date:   Mon, 6 Nov 2017 18:33:32 +0000
From:   Pieter Jansen van Vuuren <pieter.jansenvanvuuren@...ronome.com>
To:     Manish Kurup <kurup.manish@...il.com>
Cc:     jhs@...atatu.com, xiyou.wangcong@...il.com, jiri@...nulli.us,
        davem@...emloft.net, jakub.kicinski@...ronome.com,
        simon.horman@...ronome.com, john.hurley@...ronome.com,
        oss-drivers@...ronome.com, netdev@...r.kernel.org,
        aring@...atatu.com, mrv@...atatu.com,
        Manish Kurup <manish.kurup@...izon.com>
Subject: Re: [PATCH net-next v6 2/3] nfp flower action: Modified to use VLAN
 helper functions

On Fri,  3 Nov 2017 11:50:25 -0400
Manish Kurup <kurup.manish@...il.com> wrote:

> Modified netronome nfp flower action to use VLAN helper functions instead
> of accessing the structure directly.
> 
> Signed-off-by: Manish Kurup <manish.kurup@...izon.com>
> ---
>  drivers/net/ethernet/netronome/nfp/flower/action.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/netronome/nfp/flower/action.c
> b/drivers/net/ethernet/netronome/nfp/flower/action.c index de64ced..c1c595f
> 100644 --- a/drivers/net/ethernet/netronome/nfp/flower/action.c
> +++ b/drivers/net/ethernet/netronome/nfp/flower/action.c
> @@ -58,7 +58,6 @@ nfp_fl_push_vlan(struct nfp_fl_push_vlan *push_vlan,
>  		 const struct tc_action *action)
>  {
>  	size_t act_size = sizeof(struct nfp_fl_push_vlan);
> -	struct tcf_vlan *vlan = to_vlan(action);
>  	u16 tmp_push_vlan_tci;
>  
>  	push_vlan->head.jump_id = NFP_FL_ACTION_OPCODE_PUSH_VLAN;
> @@ -67,8 +66,8 @@ nfp_fl_push_vlan(struct nfp_fl_push_vlan *push_vlan,
>  	push_vlan->vlan_tpid = tcf_vlan_push_proto(action);
>  
>  	tmp_push_vlan_tci =
> -		FIELD_PREP(NFP_FL_PUSH_VLAN_PRIO, vlan->tcfv_push_prio) |
> -		FIELD_PREP(NFP_FL_PUSH_VLAN_VID, vlan->tcfv_push_vid) |
> +		FIELD_PREP(NFP_FL_PUSH_VLAN_PRIO,
> tcf_vlan_push_prio(action)) |
> +		FIELD_PREP(NFP_FL_PUSH_VLAN_VID, tcf_vlan_push_vid(action))
> | NFP_FL_PUSH_VLAN_CFI;
>  	push_vlan->vlan_tci = cpu_to_be16(tmp_push_vlan_tci);
>  }
Thank you for this; you may consider this patch:
Reviewed-by: Pieter Jansen van Vuuren <pieter.jansenvanvuuren@...ronome.com>